Skip to content

Conversation

@d3xter666
Copy link
Member

This change continues the efforts from #1132 and enhances it by enabling vitepress build of the documentation.

JIRA: CPOUI5FOUNDATION-899

@d3xter666 d3xter666 force-pushed the feat-create-docsumentation-package branch from 037ceae to 31934ec Compare October 10, 2025 11:37
@d3xter666 d3xter666 force-pushed the feat-enable-vitepress branch from 8961b0d to 7a2ce4f Compare October 10, 2025 11:39
@d3xter666 d3xter666 requested a review from a team October 10, 2025 11:41
@d3xter666 d3xter666 force-pushed the feat-create-docsumentation-package branch from 64066ac to f3a5128 Compare October 14, 2025 06:51
@d3xter666 d3xter666 force-pushed the feat-enable-vitepress branch 2 times, most recently from 6afdfe1 to 36c75f1 Compare October 14, 2025 11:02
@d3xter666 d3xter666 force-pushed the feat-create-docsumentation-package branch from 0107968 to af5446d Compare October 14, 2025 12:27
Base automatically changed from feat-create-docsumentation-package to main October 14, 2025 12:34
@d3xter666 d3xter666 force-pushed the feat-enable-vitepress branch from 7d5eba8 to 8beda5d Compare October 14, 2025 12:38
@d3xter666 d3xter666 requested a review from RandomByte October 14, 2025 13:08
@d3xter666 d3xter666 requested a review from a team October 16, 2025 06:56
@d3xter666 d3xter666 force-pushed the feat-enable-vitepress branch from c1e36b7 to a934f2a Compare October 20, 2025 09:48
@maxreichmann
Copy link
Member

/pages/CLI.html returns a 404.
It is referenced multiple times such as in the sidebar or in /pages/GettingStarted.html as "Next page"

@d3xter666 d3xter666 force-pushed the feat-enable-vitepress branch from a934f2a to c1e36b7 Compare October 21, 2025 06:25
@d3xter666
Copy link
Member Author

/pages/CLI.html returns a 404. It is referenced multiple times such as in the sidebar or in /pages/GettingStarted.html as "Next page"

The CLI page must be generated via the npm run generate-cli-doc script in the root of the monorepo

@d3xter666 d3xter666 force-pushed the feat-enable-vitepress branch from d0c7ac3 to 5311640 Compare October 21, 2025 08:37
@maxreichmann
Copy link
Member

maxreichmann commented Oct 21, 2025

Remark 1:
Wouldn't it make sense to move all the migration guide files from packages/documentation/docs/updates to the general pages directory packages/documentation/docs/pages?
We would then have all files in a combined directory and this would fix some 404 linkings e.g. of the button "Migrate to v4" on Home.html.

Remark 2:
These migration guide files contain wrongly formatted info/warning/success elements which have to be replaced.
e.g.:
image

  • For !!! tip, we can use ::: tip [...] ::: and remove the indendation
  • the same works for !!! warning
  • for !!! success, we have to find a different alternative

Since those files haven't been touched in this PR yet, I couldn't create a GH code suggestion.

@d3xter666
Copy link
Member Author

We would then have all files in a combined directory and this would fix some 404 linkings e.g. of the button "Migrate to v4" on Home.html.

My intention was to do the cleanup in the next step, but now I have fixed the formatting and links.
Thanks!

</script>

<div style="margin: 1rem 0;">
<VPButton class="no-decoration" text="📚 API Reference" href="https://ui5.github.io/cli/v4/api/"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

v4?

I wonder why we can't use relative links here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It' should be v5, indeed and I have adjusted it, but It used to be that way so far.
I was trying to just adjust the formatting and eventually something broken/wrong.

Copy link
Member

@maxreichmann maxreichmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Going through the pages I noticed..

  1. the API reference links sometimes include v4, sometimes v5 (currently 404). I suggest using stable.
  2. nit: On "Migrate to v3", the caption formatting could be improved. Since, it's v3 it might not be relevant.

@d3xter666
Copy link
Member Author

Going through the pages I noticed..

  1. the API reference links sometimes include v4, sometimes v5 (currently 404). I suggest using stable.
  2. nit: On "Migrate to v3", the caption formatting could be improved. Since, it's v3 it might not be relevant.

Thanks!
I have addressed those issues.
The 404s for API links will be fixed, once we produce a build as it will deploy to v5 (it's currently missing)

The formatting should is fine now

Copy link
Member

@matz3 matz3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a feature (feat) of UI5 CLI. It is an internal change about our documentation, so I'd propose to use docs instead.

@d3xter666 d3xter666 changed the title feat: Enable vitepress build docs: Enable vitepress build Oct 28, 2025
@d3xter666 d3xter666 dismissed RandomByte’s stale review October 28, 2025 08:06

Comments were addressed

@d3xter666 d3xter666 merged commit fdc9f69 into main Oct 28, 2025
17 checks passed
@d3xter666 d3xter666 deleted the feat-enable-vitepress branch October 28, 2025 08:06
d3xter666 added a commit to d3xter666/ui5-tooling that referenced this pull request Oct 30, 2025
This change continues the efforts from
UI5#1132 and enhances it by enabling
vitepress build of the documentation.

JIRA: CPOUI5FOUNDATION-899

---------

Co-authored-by: Max Reichmann <[email protected]>
d3xter666 added a commit to d3xter666/ui5-tooling that referenced this pull request Oct 30, 2025
* ci(github-actions): bump actions/setup-node from 5 to 6 (UI5#1163)

* docs(README.md): Use stable version in documentation links

* Bump actions/stale from 9 to 10

Bumps [actions/stale](https://github.com/actions/stale) from 9 to 10.
- [Release notes](https://github.com/actions/stale/releases)
- [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md)
- [Commits](actions/stale@v9...v10)

---
updated-dependencies:
- dependency-name: actions/stale
  dependency-version: '10'
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>

* build(deps-dev): bump koa from 2.16.2 to 2.16.3

Resolves GHSA-g8mr-fgfg-5qpc

* docs(README): Fix module overview image

Also remove unused UI5 logo image

* ci(licensee): Enable licensee check

The "only" package uses the MIT license (mentioned in README.md).
The license file and license field are missing from the package, but have
been added to the GitHub repository: https://github.com/tj/node-only

* docs: Minor changes

* ci: Add test matrix (Node 20, 22, 24 on Linux / macOS / Windows)

Also update checkout action to latest version.

* docs: Enable vitepress build (UI5#1133)

This change continues the efforts from
UI5#1132 and enhances it by enabling
vitepress build of the documentation.

JIRA: CPOUI5FOUNDATION-899

---------

Co-authored-by: Max Reichmann <[email protected]>

* refactor: Create separate package for documentation

* refactor: Move /docs to the newly create package

* refactor: Guidelines are for the whole project and should be at the top level

* refactor: Move /docs to the newly create package

* feat: Add vitepress & config

* feat: Add gitignore rules for the documentation build

* refactor: Make md files vitepress compatible

* fix: CLI.md parsing for vitepress

* feat: Cleanup documentation (UI5#1135)

This PR aims to cleanup redundant files & configurations from the legacy
MkDocs build

JIRA: CPOUI5FOUNDATION-899

* refactor: Remove unnecessary files from .git

* refactor: Enable .git ignore rules after cleanup

* refactor: Correct .gitignore rules

* refactor: Cleanup redundant configurations

* refactor: Use light & dark logos

* fix: Restore Guidelines.md

* refactor: Use vitepress buttons

* refactor: Cleanup

* fix: Remove redundant formatting

* refactor: Align indexes

* refactor: Align indexes

* fix: Bad links

* fix: Markdowns formatting

* fix: Internal links

* refactor: Create separate package for documentation

* refactor: Move /docs to the newly create package

* fix: Adjust paths

* feat: Add vitepress & config

* refactor: Make md files vitepress compatible

* fix: CLI.md parsing for vitepress

* feat: Enable GH next docs deployment

* refactor: Adjust scripts

* fix: Try to run docs properly

* fix: Adjust version links

* feat: Update alias

* docs: Thank you note

* refactor: Use Vue buttons, instead of HTML tags

* fix: Documentation syntax

* refactor: Provide correct base for the documentation

* refactor: Update general links to v4

* docs: Update REUSE.toml to reference the vitepress license and contributors

* docs: JSDoc cleanup

* fix: Address docs CI to the correct branch

* docs: Fix index next link

* docs: Images for dark and light mode

* fix: Provide correct dark logos

* fix: Merge conflicts

* fix: Merge conflicts

* refactor: Adjust config.ts

* fix: Rebase missmatches

* fix: Add contributors

* refactor: Sync packages with main

* fix: Merge conflicts

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Florian Vogt <[email protected]>
Co-authored-by: Matthias Osswald <[email protected]>
Co-authored-by: Max Reichmann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants