-
Notifications
You must be signed in to change notification settings - Fork 76
docs: Enable vitepress build #1133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
037ceae to
31934ec
Compare
8961b0d to
7a2ce4f
Compare
64066ac to
f3a5128
Compare
6afdfe1 to
36c75f1
Compare
0107968 to
af5446d
Compare
7d5eba8 to
8beda5d
Compare
c1e36b7 to
a934f2a
Compare
|
|
a934f2a to
c1e36b7
Compare
The CLI page must be generated via the |
d0c7ac3 to
5311640
Compare
My intention was to do the cleanup in the next step, but now I have fixed the formatting and links. |
packages/documentation/docs/pages/extensibility/ProjectShims.md
Outdated
Show resolved
Hide resolved
| </script> | ||
|
|
||
| <div style="margin: 1rem 0;"> | ||
| <VPButton class="no-decoration" text="📚 API Reference" href="https://ui5.github.io/cli/v4/api/"/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
v4?
I wonder why we can't use relative links here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It' should be v5, indeed and I have adjusted it, but It used to be that way so far.
I was trying to just adjust the formatting and eventually something broken/wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going through the pages I noticed..
- the API reference links sometimes include
v4, sometimesv5(currently 404). I suggest usingstable. - nit: On "Migrate to v3", the caption formatting could be improved. Since, it's v3 it might not be relevant.
Thanks! The formatting should is fine now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a feature (feat) of UI5 CLI. It is an internal change about our documentation, so I'd propose to use docs instead.
This change continues the efforts from UI5#1132 and enhances it by enabling vitepress build of the documentation. JIRA: CPOUI5FOUNDATION-899 --------- Co-authored-by: Max Reichmann <[email protected]>
* ci(github-actions): bump actions/setup-node from 5 to 6 (UI5#1163) * docs(README.md): Use stable version in documentation links * Bump actions/stale from 9 to 10 Bumps [actions/stale](https://github.com/actions/stale) from 9 to 10. - [Release notes](https://github.com/actions/stale/releases) - [Changelog](https://github.com/actions/stale/blob/main/CHANGELOG.md) - [Commits](actions/stale@v9...v10) --- updated-dependencies: - dependency-name: actions/stale dependency-version: '10' dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * build(deps-dev): bump koa from 2.16.2 to 2.16.3 Resolves GHSA-g8mr-fgfg-5qpc * docs(README): Fix module overview image Also remove unused UI5 logo image * ci(licensee): Enable licensee check The "only" package uses the MIT license (mentioned in README.md). The license file and license field are missing from the package, but have been added to the GitHub repository: https://github.com/tj/node-only * docs: Minor changes * ci: Add test matrix (Node 20, 22, 24 on Linux / macOS / Windows) Also update checkout action to latest version. * docs: Enable vitepress build (UI5#1133) This change continues the efforts from UI5#1132 and enhances it by enabling vitepress build of the documentation. JIRA: CPOUI5FOUNDATION-899 --------- Co-authored-by: Max Reichmann <[email protected]> * refactor: Create separate package for documentation * refactor: Move /docs to the newly create package * refactor: Guidelines are for the whole project and should be at the top level * refactor: Move /docs to the newly create package * feat: Add vitepress & config * feat: Add gitignore rules for the documentation build * refactor: Make md files vitepress compatible * fix: CLI.md parsing for vitepress * feat: Cleanup documentation (UI5#1135) This PR aims to cleanup redundant files & configurations from the legacy MkDocs build JIRA: CPOUI5FOUNDATION-899 * refactor: Remove unnecessary files from .git * refactor: Enable .git ignore rules after cleanup * refactor: Correct .gitignore rules * refactor: Cleanup redundant configurations * refactor: Use light & dark logos * fix: Restore Guidelines.md * refactor: Use vitepress buttons * refactor: Cleanup * fix: Remove redundant formatting * refactor: Align indexes * refactor: Align indexes * fix: Bad links * fix: Markdowns formatting * fix: Internal links * refactor: Create separate package for documentation * refactor: Move /docs to the newly create package * fix: Adjust paths * feat: Add vitepress & config * refactor: Make md files vitepress compatible * fix: CLI.md parsing for vitepress * feat: Enable GH next docs deployment * refactor: Adjust scripts * fix: Try to run docs properly * fix: Adjust version links * feat: Update alias * docs: Thank you note * refactor: Use Vue buttons, instead of HTML tags * fix: Documentation syntax * refactor: Provide correct base for the documentation * refactor: Update general links to v4 * docs: Update REUSE.toml to reference the vitepress license and contributors * docs: JSDoc cleanup * fix: Address docs CI to the correct branch * docs: Fix index next link * docs: Images for dark and light mode * fix: Provide correct dark logos * fix: Merge conflicts * fix: Merge conflicts * refactor: Adjust config.ts * fix: Rebase missmatches * fix: Add contributors * refactor: Sync packages with main * fix: Merge conflicts --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Florian Vogt <[email protected]> Co-authored-by: Matthias Osswald <[email protected]> Co-authored-by: Max Reichmann <[email protected]>

This change continues the efforts from #1132 and enhances it by enabling vitepress build of the documentation.
JIRA: CPOUI5FOUNDATION-899